Add bundle_root_path to deployment metadata workspace info#5665
Open
ilyakuz-db wants to merge 1 commit into
Open
Add bundle_root_path to deployment metadata workspace info#5665ilyakuz-db wants to merge 1 commit into
ilyakuz-db wants to merge 1 commit into
Conversation
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 82714a7
22 interesting tests: 13 SKIP, 7 RECOVERED, 2 flaky
Top 30 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
bundle_root_pathto the deployment metadataWorkspaceInfo— both thetmpdmstype sent onCreateVersionand the populating logic inworkspaceInfo(). It records the bundle root path relative to the git folder, sourced fromb.Config.Bundle.Git.BundleRootPath.Why
The deployment-details UI links a deployment's "Source" to the bundle folder (the folder containing
databricks.yml). Today onlygit_folder_path(the git repo root) is recorded, so the link resolves the repo root instead of the bundle root when the bundle lives in a subfolder. Recordingbundle_root_pathlets the UI resolve the actual bundle folder viajoin(git_folder_path, bundle_root_path). Mirrors the value already written tometadata.json.Gated on the same workspace Git-folder condition as
git_folder_path:BundleRootPathdefaults to"."(filepath.Relreturns"."when bundle root == worktree root), so it is only meaningful for workspace Git-folder deploys. This intentionally diverges frommetadata.json(which writes it unconditionally undergit).Needs the matching
bundle_root_pathfield on the DMS proto (separate universe PR).Tests
Extended the existing
workspaceInfounit tests: local deploy assertsbundle_root_pathstays empty; git-folder deploy asserts it round-trips.