bundle/direct/dstate: add GetOrInitLineage, the single lineage init point#5667
Draft
shreyas-goenka wants to merge 1 commit into
Draft
bundle/direct/dstate: add GetOrInitLineage, the single lineage init point#5667shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
…oint Extract lineage initialization into GetOrInitLineage and route Open (write branch) and UpgradeToWrite through it, so there is exactly one place the deployment lineage is read-or-generated. The lineage is now readable in read mode (before planning), not only when the engine opens the WAL for write, and the same value is written to the WAL header — so a later consumer (the Deployment Metadata Service) and the deployment engine always agree on it. No behavioral change to the persisted state: the lineage value and WAL/state output are unchanged; only the in-memory init is consolidated and exposed. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
Collaborator
Integration test reportCommit: b54278c
20 interesting tests: 13 SKIP, 7 RECOVERED
Top 26 slowest tests (at least 2 minutes):
|
denik
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundation for recording deployment history in the Deployment Metadata Service (DMS). Split out from #5386 so the state-layer change can be reviewed on its own.
Extracts lineage initialization into a single
GetOrInitLineage()method and routesOpen(write branch) andUpgradeToWritethrough it. The deployment lineage is now:No behavioral change to persisted state — the lineage value and WAL/state output are unchanged; only the in-memory init is consolidated and exposed. Covered by a new
dstateunit test.The consumer that uses this lineage to record DMS versions is #5386 (stacked on this).