fix(skills): quote databricks-app-design description; guard skill frontmatter#161
Merged
Conversation
…ntmatter The databricks-app-design SKILL.md description was an unquoted YAML scalar containing a colon, so strict-YAML loaders (e.g. omnigents) rejected it with "mapping values are not allowed here" and silently dropped the skill at load time. Quote the value (matching every other skill that has a colon in its description). Add check_skill_frontmatter to the validate flow so any skill (stable or experimental) with missing or unquoted-colon description frontmatter fails CI, closing the gap that let this through (only commands/ were checked before). Co-authored-by: Isaac
…ml rationale State directly why the guard uses a regex instead of yaml.safe_load (the package is stdlib-only; the protected CI runner has no pypi), and drop the sentence that just restated the if/elif chain. No behavior change. Co-authored-by: Isaac
…agged) Rounds out the SkillFrontmatterTest truth table and guards against the regex over-matching plain scalars. Previously only implicit via test_repo_skills_are_clean. Co-authored-by: Isaac
pkosiec
requested review from
a team,
lennartkats-db and
simonfaltum
as code owners
simonfaltum
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
descriptioninskills/databricks-app-design/SKILL.md. It was an unquoted YAML scalar containing a colon (...answers data questions: choosing genre...), which strict-YAML loaders (e.g.omnigents) reject with "mapping values are not allowed here", silently dropping the skill at load time. Every other skill with a colon in its description already quotes it.check_skill_frontmattertoscripts/skills.py validateso any skill (stable or experimental) with missing or unquoted-colondescriptionfrontmatter fails CI. Closes the gap that let this through — onlycommands/were checked before.Verify
omnigentsuses): fixed frontmatter parses; the old form raises the exact reported error.python3 scripts/skills.py validate→ clean; exits non-zero on the reverted bug.SkillFrontmatterTest.Manifest output is unchanged (the extractor strips outer quotes), so no regeneration is needed.
This pull request and its description were written by Isaac.