Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions service/sql/ext_utilities.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,14 @@ func (a *StatementExecutionAPI) ExecuteAndWait(ctx context.Context, request Exec
}
return nil, fmt.Errorf("%s", msg)
default:
// TODO: parse request.WaitTimeout and use it here
return retries.Poll[StatementResponse](ctx, 20*time.Minute,
timeout := 20 * time.Minute
if request.WaitTimeout != "" {
wTimeout, err := time.ParseDuration(request.WaitTimeout)
if err == nil && wTimeout > 0 {
timeout = wTimeout
}
}
return retries.Poll[StatementResponse](ctx, timeout,
func() (*StatementResponse, *retries.Err) {
res, err := a.GetStatementByStatementId(ctx, immediateResponse.StatementId)
if err != nil {
Expand Down
86 changes: 86 additions & 0 deletions service/sql/ext_utilities_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
package sql

import (
"context"
"testing"
"time"

"github.com/databricks/databricks-sdk-go/qa"
)

func TestExecuteAndWait_DefaultTimeout(t *testing.T) {
client, server := qa.HTTPFixtures{
{
Method: "POST",
Resource: "/api/2.0/sql/statements",
Response: StatementResponse{
StatementId: "123",
Status: &StatementStatus{
State: StatementStateSucceeded,
},
},
},
}.Client(t)
defer server.Close()

ctx := context.Background()
api := NewStatementExecution(client)
resp, err := api.ExecuteAndWait(ctx, ExecuteStatementRequest{
WarehouseId: "wh-1",
Statement: "SELECT 1",
})
if err != nil {
t.Fatalf("unexpected error: %s", err)
}
if resp.StatementId != "123" {
t.Errorf("expected statement id 123, got %s", resp.StatementId)
}
}

func TestExecuteAndWait_CustomTimeoutExceeded(t *testing.T) {
client, server := qa.HTTPFixtures{
{
Method: "POST",
Resource: "/api/2.0/sql/statements",
Response: StatementResponse{
StatementId: "123",
Status: &StatementStatus{
State: StatementStatePending,
},
},
},
{
Method: "GET",
ReuseRequest: true,
Resource: "/api/2.0/sql/statements/123",
Response: StatementResponse{
StatementId: "123",
Status: &StatementStatus{
State: StatementStateRunning,
},
},
},
}.Client(t)
defer server.Close()

ctx := context.Background()
api := NewStatementExecution(client)

start := time.Now()
_, err := api.ExecuteAndWait(ctx, ExecuteStatementRequest{
WarehouseId: "wh-1",
Statement: "SELECT 1",
WaitTimeout: "500ms",
})
elapsed := time.Since(start)

if err == nil {
t.Fatal("expected timeout error, got nil")
}

// We expect the polling to timeout around 500ms.
// Allow some buffer (e.g., up to 2s) to prevent transient test failures.
if elapsed > 2*time.Second {
t.Errorf("expected poll to timeout quickly, took %s", elapsed)
}
}
Loading