Custom serializers for Google Protobuf Types#467
Closed
hectorcast-db wants to merge 8 commits into
Closed
Conversation
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
changed the title
parthban-db
reviewed
Jun 19, 2025
parthban-db
left a comment
parthban-db
left a comment
Contributor
There was a problem hiding this comment.
Can we add unit tests for these classes?
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
parthban-db
reviewed
Jun 20, 2025
parthban-db
left a comment
parthban-db
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo a small question.
|
|
||
| static Stream<Arguments> durationDeserializationTestCases() { | ||
| return Stream.of( | ||
| // Duration with seconds and nanos |
Contributor
There was a problem hiding this comment.
Do Java tests comments also end with a period?
Contributor
Author
There was a problem hiding this comment.
If its a full sentence, but not for short phrases.
parthban-db
approved these changes
Jun 20, 2025
Contributor
Author
|
jenkins merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Custom serializers for Google Protobuf Types. This is required because Jackson by default does not consider that such objects have a special serialization.
How is this tested?
Tested as part of supporting well known types
https://github.com/databricks/databricks-sdk-java/pull/459/files#diff-c3aa175ce608f5cd289331f74de4e21ddcd56fc195ec92b028f2e7d4a6d721e6
NO_CHANGELOG=true