[PECOBLR-15] Respect OAuth Discovery URL for ExternalBrowserCredentialsStrategy#505
Merged
mgyucht merged 13 commits intoSep 17, 2025
Merged
Conversation
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
changed the title
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
changed the title
mgyucht
reviewed
Sep 16, 2025
mgyucht
left a comment
mgyucht
left a comment
Contributor
There was a problem hiding this comment.
For this PR, can we split out the fallback-to-default behavior to a separate discussion? Otherwise, the changes to the ExternalBrowserCredentialsStrategy and OAuthClient seem good to me.
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
samikshya-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
samikshya-db
added a commit
to databricks/databricks-jdbc
that referenced
this pull request
Sep 18, 2025
) ## Description - This is to support Discovery URL for U2M AWS and GCP in OSS JDBC databricks/databricks-sdk-java#505 (Note azure is not supported as it has a different flow in OSS JDBC) ## Testing Tested that discovery URL is being honored in U2M as well. Tested this using the OSS JDBC with the following URL 1. Success flow test : ``` String jdbcUrl = "jdbc:databricks://e2-dogfood.staging.cloud.databricks.com:443/default;transportMode=http;ssl=1;httpPath=/sql/1.0/warehouses/dd43ee29fedd958d;" + "AuthMech=11;Auth_Flow=2;LogLevel=6;UseThriftClient=0;EnableTokenCache=0;OIDCDiscoveryEndpoint=https://e2-dogfood.staging.cloud.databricks.com/oidc/.well-known/oauth-authorization-server"; ``` 2. Failure flow test : ``` String jdbcUrl = "jdbc:databricks://e2-dogfood.staging.cloud.databricks.com:443/default;transportMode=http;ssl=1;httpPath=/sql/1.0/warehouses/dd43ee29fedd958d;" + "AuthMech=11;Auth_Flow=2;LogLevel=6;UseThriftClient=0;EnableTokenCache=0;OIDCDiscoveryEndpoint=https://google.com"; ``` Also tested using GCP : ``` "jdbc:databricks://6177827686947384.4.gcp.databricks.com:443/default;transportMode=http;ssl=1;EnableTokenCache=0;AuthMech=11;Auth_Flow=2;httpPath=/sql/1.0/warehouses/f5e97c8f8dfb56b5;OIDCDiscoveryEndpoint=https://6177827686947384.4.gcp.databricks.com/oidc/.well-known/oauth-authorization-server"; ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
I have also added a fallback to defaultOIDC flow to make this backward compatible too.skipped the fallback in this PR, will raise in a followup if I get approval from the SDK teamHow is this tested?
Tested that discovery URL is being honored in U2M as well. Tested this using the OSS JDBC with the following URL