Add an option to disable adding the offline_access scope by default in OAuth exchanges.#525
Merged
Merged
Conversation
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
## What changes are proposed in this pull request? We recently added support for disabling auto token refresh (#525). The current code is hardcoded to handle refreshable tokens, and it forcefully refreshes the token on every call of `configure()` This PR proposed using a token (no matter if it is refreshable or not) if it is valid. Once the ExternalBrowserCredentialsProvider is run, it stores the token on disk. If the application is run again, it checks the token and tries to use it. ## How is this tested? Added Unit tests NO_CHANGELOG=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds the
DATABRICKS_DISABLE_OAUTH_REFRESH_TOKENoption inDatabricksConfigto disable automatically requesting a refresh token (by adding theoffline_accessscope) in OAuth flow. Note that this option does not remove the scope from the user provided scopes if present.How is this tested?
Unit + Integration tests.