Add X-Databricks-Org-Id header to hand-written extensions for SPOG hosts#1389
Open
simonfaltum wants to merge 1 commit intomainfrom
Open
Add X-Databricks-Org-Id header to hand-written extensions for SPOG hosts#1389simonfaltum wants to merge 1 commit intomainfrom
simonfaltum wants to merge 1 commit intomainfrom
Conversation
…SPOG host compatibility Hand-written mixin methods that make direct _api.do() calls were missing the X-Databricks-Org-Id header that SPOG hosts require for routing. The generated service methods already include this header per-call, but Workspace.upload(), Workspace.download(), Shares.list(), and ServingEndpoints.http_request() were missing it. Co-authored-by: Isaac
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
databricks bundle deployfails on SPOG hosts with "Unable to load OAuth Config" errors when using hand-written extension methods that make direct_api.do()calls. These methods bypass the generated code path that includes theX-Databricks-Org-Idheader required for SPOG routing.The generated service methods already include this header per-call, but the hand-written mixins were missing it.
Linked Go SDK PR: databricks/databricks-sdk-go#1634
Changes
Added the
X-Databricks-Org-Idheader (whenworkspace_idis configured) to the following hand-written mixin methods:WorkspaceExt.upload()inmixins/workspace.pyWorkspaceExt.download()inmixins/workspace.pySharesExt.list()inmixins/sharing.pyServingEndpointsExt.http_request()inmixins/open_ai_client.pyUses the same pattern as generated code:
Test plan
python -c "from databricks.sdk.mixins.workspace import WorkspaceExt"passesThis pull request was AI-assisted by Isaac.