Skip to content

Stop exporting agentProvider from @databricks/sdk-core#89

Merged
parthban-db merged 1 commit into
mainfrom
simonfaltum/unexport-agent-provider
Apr 20, 2026
Merged

Stop exporting agentProvider from @databricks/sdk-core#89
parthban-db merged 1 commit into
mainfrom
simonfaltum/unexport-agent-provider

Conversation

@simonfaltum

Copy link
Copy Markdown
Member

Summary

  • Removes the public re-export of agentProvider from @databricks/sdk-core.
  • agentProvider is an internal detail of the clientinfo subsystem. The only in-repo caller (default.ts) imports it directly from ./agent, and there's no reason for consumers of the SDK to reach for it themselves.
  • Addresses Parth's review comment on Add AI agent detection to user-agent header #88.

Test plan

  • npm test --workspace=packages/core (242 tests pass)
  • npm run lint --workspace=packages/core
  • npm run typecheck --workspace=packages/core
  • npm run format

This pull request and its description were written by Isaac.

agentProvider is an internal detail of clientinfo. The only consumer
inside the SDK (default.ts) imports it directly from ./agent, so the
public re-export had no user-facing purpose. Addresses review feedback
from #88.

Co-authored-by: Isaac
Signed-off-by: simon <simon.faltum@databricks.com>
@simonfaltum simonfaltum requested a review from parthban-db April 20, 2026 14:09
@parthban-db parthban-db added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit 7519e22 Apr 20, 2026
9 checks passed
@parthban-db parthban-db deleted the simonfaltum/unexport-agent-provider branch April 20, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants