Skip to content

fix(client): wait for output pump before exit to prevent truncated stdout #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
He-Pin wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

fix(client): wait for output pump before exit to prevent truncated stdout #1009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sjsonnet/client/src/sjsonnet/client/SjsonnetClientMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ public static int run(String lockBase,

locks.serverLock.await();

// The server closes its end of the socket before releasing serverLock,
// so the output pumper will see EOF. Wait for it to finish so that all
// output is fully written to stdout/stderr before we exit. Without this
// join, System.exit() kills the daemon thread mid-pump, which can result
// in empty or truncated output (flaky test: secondInvocationReusesServer).
outThread.join(5_000);

try {
String content = Files.readString(Path.of(lockBase, "exitCode"), StandardCharsets.UTF_8);
return Integer.parseInt(content.trim());
Expand Down
Loading