[PECO-1628] Tableau Connector Update for New BI CUJ#68
Draft
jeremytang-db wants to merge 6 commits intomasterfrom
Draft
[PECO-1628] Tableau Connector Update for New BI CUJ#68jeremytang-db wants to merge 6 commits intomasterfrom
jeremytang-db wants to merge 6 commits intomasterfrom
Conversation
jeremytang-db
commented
Jul 10, 2024
| // If the HTTP path is empty, use the default HTTP path. | ||
| if(params["HTTPPATH"] == "") | ||
| { | ||
| params["HTTPPATH"] = attr["default-http-path"]; |
Contributor
Author
There was a problem hiding this comment.
This line doesn't do anything right now, but if we go with Option 1, we should update the v-http-path with default-http-path if it is empty. Waiting for Tableau but not sure if we wouldn't have to do this manually like this or they will have that change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make http path field optional for OAuth auth mode. Update oauth url to include "prompt=select-warehouse".
TODO:
Save default-http-path for v-http-path if it is empty (for Backwards Compatibility)