avoid 0 as streetAddressNumber#1774
Conversation
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
============================================
- Coverage 92.40% 92.33% -0.08%
+ Complexity 3449 3446 -3
============================================
Files 339 339
Lines 6794 6794
Branches 670 670
============================================
- Hits 6278 6273 -5
- Misses 352 354 +2
- Partials 164 167 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I've just stumbled across a failed test and found that datafaker produced '0' as streetAddressNumber.
IMHO that makes no sense, so I fixed it to use a random number between 1 and 1000 instead of 0 and 1000 (with min and max included in both cases).
I've also did some naming cleanup in related tests as they kind of confused me in the very beginning.