Ensure connections always reconnect deterministically after a server disconnect (or crash).

[ctheune]

Replaces #6 with further fixes to the tests.

[coveralls]

Pull Request Test Coverage Report for Build 16775300324

Details

• 18 of 21 (85.71%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.3%) to 90.583%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/Products/ZPsycopgDA/db.py	18	21	85.71%

Files with Coverage Reduction	New Missed Lines	%
src/Products/ZPsycopgDA/pool.py	1	75.84%

Totals
Change from base Build 16705090510:	0.3%
Covered Lines:	737
Relevant Lines:	800

---

💛 - Coveralls

[sweh]

@ctheune Das läuft hier bisher sehr stabil. Kannst den PR gern zum Merge und Release freigeben. 👍🏻

[dataflake]

There's no point in holding this forever. We will just have to see if this works for everyone.

[sweh]

Hi there,

we had to roll back to 4.2 as we had problems with 4.3 in production.

The error in the log is unfortunately not very informative: InterfaceError: connection already closed. The error only occurs sporadically.

I remember @ctheune saying to me in person that he wanted to write more tests because he had discovered another bug. Was it fixed before the release?

Best regards,
Sebastian

[dataflake]

No it wasn't fixed. There was no reaction from @ctheune in 2 months and I wanted to get this stuff off my desk.

[sweh]

No it wasn't fixed. There was no reaction from @ctheune in 2 months and I wanted to get this stuff off my desk.

That's okay, @ctheune is very busy afaik. Perhaps he could write briefly and say whether he sees any open problems.

[dataflake]

Let me know if you think this error is so common that everyone would see it, if needed I will yank the release from PyPI.

[dataflake]

Knowing that the patch did not work as expected and not getting any feedback I decided the situation where I have a release out with code that does not work in some situations is not acceptable. I have reverted the connection code changes so it's back to where it was in release 4.2 and released version 4.4. If you come up with a tested solution that you know will work I'll help you get it released.