fix: delete duplicate tool file, fix status code check, move dev deps#38
Open
domdomdomdomdomdomdomdomdom wants to merge 1 commit intodataforseo:masterfrom
Conversation
- Delete backlinks-bulk-spam-score.ts (duplicate of .tool.ts with wrong tool name suffix). The module already imports from .tool.ts. - Fix status_code validation in base.tool.ts: use Math.floor() to handle non-round status codes like 20100 correctly (20100/100=201, not 200). - Move wrangler and agents from dependencies to devDependencies since they are only needed for development/build, not at runtime. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backlinks-bulk-spam-score.tswhich was a duplicate ofbacklinks-bulk-spam-score.tool.tswith an incorrect tool name (backlinks_bulk_spam_score_toolinstead ofbacklinks_bulk_spam_score). The module already imports from.tool.ts.status_code / 100 !== 200toMath.floor(status_code / 100) !== 200inbase.tool.ts. The original check works by accident for20000(20000/100=200) but would fail for codes like20100(20100/100=201). All three occurrences fixed.wranglerandagentsfromdependenciestodevDependenciessince they are only needed for development/build (Cloudflare Worker dev/deploy), not at runtime.Test plan
npm run buildcompiles successfully after all changes.tool.ts, not the deleted.ts)🤖 Generated with Claude Code