Fix bug in .xport format handling in extractor#6
Merged
Sallsamba merged 6 commits intoJun 11, 2025
Merged
Conversation
Contributor
|
Could we avoid always dumping the file onto disk? And do something like that: |
apichery
approved these changes
Jun 11, 2025
apichery
left a comment
apichery
left a comment
Contributor
There was a problem hiding this comment.
Did not test but code LGTM
Sallsamba
deleted the
bug/dss14-sc-247203-sas-with-pandas-plugin-cannot-read-xport-file
branch
June 11, 2025 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XPORT have a different structure than SAS7BDAT and need unsupported seek mode. So for now, let's force the "dump to file" option to handle them.
When dumping them to file, we modified the method
read_schema()to detect the format and use the correct source of metadata.PS : Right now, there is a custom field to specify between sas7bdat or xport format. Maybe the plugin could detect it automatically ? (and also avoid getting an error message everytime a xport file is getting loaded, before specifying its format)
