Skip to content

Fix reading of headers which are in binary format#7

Merged
apichery merged 2 commits into
mainfrom
bug/dss14-sc-247203-sas-with-pandas-plugin-cannot-read-xport-file2
Jul 9, 2025
Merged

Fix reading of headers which are in binary format#7
apichery merged 2 commits into
mainfrom
bug/dss14-sc-247203-sas-with-pandas-plugin-cannot-read-xport-file2

Conversation

@apichery

@apichery apichery commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Sallsamba
Sallsamba self-requested a review July 9, 2025 08:53

@Sallsamba Sallsamba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, thanks for the fix!

(I also checked if this was needed for the sas7bdat format. It seems pandas always correctly decodes the column names to strings for sas7bdat files)

@apichery
apichery merged commit 720e8cc into main Jul 9, 2025
1 of 3 checks passed
@RoyTeddy
RoyTeddy deleted the bug/dss14-sc-247203-sas-with-pandas-plugin-cannot-read-xport-file2 branch July 10, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants