Skip to content

feat: add community files and extract proxy port constants#434

Closed
ykd007 wants to merge 1 commit into
dataiku:mainfrom
ykd007:feat/community-files
Closed

feat: add community files and extract proxy port constants#434
ykd007 wants to merge 1 commit into
dataiku:mainfrom
ykd007:feat/community-files

Conversation

@ykd007
Copy link
Copy Markdown

@ykd007 ykd007 commented May 13, 2026

Description

This PR addresses four community/maintainability issues in one pass:

#433 — Extract hardcoded proxy ports as named constants
Added DefaultForwardProxyPort = ":8080" and DefaultTransparentProxyPort = ":8081" near the top of src/backend/config/config.go. Replaced all hardcoded string literals with these constants (including the fallback in server.go).

#424 — Add CONTRIBUTING.md
New CONTRIBUTING.md at the repo root covering: prerequisites, dev setup, running backend and frontend tests, branching and PR conventions, and code style guidance for both Go and TypeScript.

#425 — Add PR template
New .github/PULL_REQUEST_TEMPLATE.md with sections for description, linked issue (Closes #), testing done, and a pre-submit checklist.

#426 — Add feature request issue template
New .github/ISSUE_TEMPLATE/feature_request.yml with structured fields: problem, proposed solution, alternatives considered, and additional context.

Linked Issues

Closes #433
Closes #424
Closes #425
Closes #426

Testing Done

  • Verified Go source compiles with the constant substitutions in place (module-level go build is consistent with pre-existing import path setup).
  • All new files are well-formed (YAML validated, Markdown renders correctly).
  • No logic changes beyond the constant extraction.

Checklist

  • Constants replace all hardcoded :8080/:8081 occurrences in config and server packages
  • CONTRIBUTING.md is concise and practical
  • PR template includes description, linked issue, testing, and checklist
  • Feature request template uses GitHub Forms YAML with required/optional fields
  • No unrelated changes included

- Extract hardcoded proxy ports into named constants in config.go:
  DefaultForwardProxyPort (:8080) and DefaultTransparentProxyPort (:8081).
  Replace all hardcoded occurrences with these constants.
- Add CONTRIBUTING.md covering dev setup, running tests, branch/PR
  conventions, and code style guidelines.
- Add .github/PULL_REQUEST_TEMPLATE.md with description, linked issue,
  testing done, and a pre-submit checklist.
- Add .github/ISSUE_TEMPLATE/feature_request.yml with structured fields
  for problem, proposed solution, alternatives, and context.

Closes dataiku#433, dataiku#424, dataiku#425, dataiku#426
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ykd007 ykd007 changed the title Add community files and extract proxy port constants feat: add community files and extract proxy port constants May 13, 2026
@ykd007
Copy link
Copy Markdown
Author

ykd007 commented May 13, 2026

I have read the CLA Document and I hereby sign the CLA

@hanneshapke
Copy link
Copy Markdown
Collaborator

Hi @ykd007
Thank you for your fantastic contribution! Would you mind breaking up the PR in one PR per issue?
That will speed up the review and merge.

Thank you!

@ykd007
Copy link
Copy Markdown
Author

ykd007 commented May 14, 2026

Hi @hanneshapke — split into 4 focused PRs as requested:

Closing this combined PR. Thanks for the feedback!

@ykd007 ykd007 closed this May 14, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants