feat: add community files and extract proxy port constants#434
Closed
ykd007 wants to merge 1 commit into
Closed
Conversation
- Extract hardcoded proxy ports into named constants in config.go: DefaultForwardProxyPort (:8080) and DefaultTransparentProxyPort (:8081). Replace all hardcoded occurrences with these constants. - Add CONTRIBUTING.md covering dev setup, running tests, branch/PR conventions, and code style guidelines. - Add .github/PULL_REQUEST_TEMPLATE.md with description, linked issue, testing done, and a pre-submit checklist. - Add .github/ISSUE_TEMPLATE/feature_request.yml with structured fields for problem, proposed solution, alternatives, and context. Closes dataiku#433, dataiku#424, dataiku#425, dataiku#426
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
Hi @ykd007 Thank you! |
Author
|
Hi @hanneshapke — split into 4 focused PRs as requested:
Closing this combined PR. Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses four community/maintainability issues in one pass:
#433 — Extract hardcoded proxy ports as named constants
Added
DefaultForwardProxyPort = ":8080"andDefaultTransparentProxyPort = ":8081"near the top ofsrc/backend/config/config.go. Replaced all hardcoded string literals with these constants (including the fallback inserver.go).#424 — Add CONTRIBUTING.md
New
CONTRIBUTING.mdat the repo root covering: prerequisites, dev setup, running backend and frontend tests, branching and PR conventions, and code style guidance for both Go and TypeScript.#425 — Add PR template
New
.github/PULL_REQUEST_TEMPLATE.mdwith sections for description, linked issue (Closes #), testing done, and a pre-submit checklist.#426 — Add feature request issue template
New
.github/ISSUE_TEMPLATE/feature_request.ymlwith structured fields: problem, proposed solution, alternatives considered, and additional context.Linked Issues
Closes #433
Closes #424
Closes #425
Closes #426
Testing Done
go buildis consistent with pre-existing import path setup).Checklist
:8080/:8081occurrences in config and server packages