Conversation
❌ Deploy Preview for datalayer-desktop failed.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the project to use the latest versions of core dependencies, primarily upgrading @datalayer/core from v0.0.13 to v1.0.1. The changes reflect a major refactoring in the core library where the type structure has been reorganized, requiring updates to import paths throughout the codebase.
Changes:
- Added TypeScript library build configuration (tsconfig.lib.json) with dedicated lib output directory
- Updated all import paths from
@datalayer/core/lib/client/modelsto@datalayer/core/lib/models - Updated UserJSON imports from
Usermodule toUserDTOmodule - Upgraded major dependencies:
@datalayer/core(^1.0.1),@datalayer/jupyter-react(^2.0.3),@datalayer/lexical-loro(^1.0.0),@primer/react(^37.19.0) - Updated GitHub workflow to use official datalayer/core repository with refact/models branch
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.lib.json | New TypeScript configuration for library builds targeting lib/ output directory |
| .gitignore | Added lib/ directory to ignore list for build artifacts |
| package.json | Updated dependency versions and added type-check:watch script |
| .github/workflows/build.yml | Changed core repository reference from goanpeca/core to datalayer/core with refact/models branch |
| src/shared/types/*.ts | Updated import paths from client/models to models structure |
| src/renderer/**/*.tsx | Updated type imports to use new models path structure |
| src/preload/index.ts | Updated type imports for models and UserDTO |
| src/main/services/datalayer-sdk-bridge.ts | Updated UserJSON import to use UserDTO module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@primer/react": "^36.27.0", | ||
| "@primer/react-brand": "^0.58.1", | ||
| "@primer/react": "^37.19.0", | ||
| "@primer/react-brand": "^0.58.0", |
There was a problem hiding this comment.
The version of @primer/react-brand is being downgraded from ^0.58.1 to ^0.58.0. This appears to be a backwards change rather than an upgrade. Please verify this is intentional or if it should be upgraded to a newer version instead.
| "@primer/react-brand": "^0.58.0", | |
| "@primer/react-brand": "^0.58.1", |
2 participants
Uh oh!
There was an error while loading. Please reload this page.