Updating singer_stream.py to allow schemas without properties#220
Open
lucas wants to merge 6 commits intodatamill-co:masterfrom
Open
Updating singer_stream.py to allow schemas without properties#220lucas wants to merge 6 commits intodatamill-co:masterfrom
lucas wants to merge 6 commits intodatamill-co:masterfrom
Conversation
While utilizing tap-zendesk (https://github.com/twilio-labs/twilio-tap-zendesk) there are some cases where the generated schema does not include a `properties` key in the dictionary, causing the `properties = self.schema['properties']` to fail. Given that there is nothing returned from this function, returning early appears to resolve it.
laurentS
reviewed
Aug 29, 2022
Collaborator
laurentS
left a comment
laurentS
left a comment
There was a problem hiding this comment.
What do you think of the approach below instead?
Collaborator
|
Quick sense-check on this, is the absence of |
Updating dependencies
update arrow dep
fix type
Collaborator
|
@lucas would you be able to merge the main branch into this PR to switch to the new dependency management format (pyproject.toml)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While utilizing tap-zendesk (https://github.com/twilio-labs/twilio-tap-zendesk) there are some cases where the generated schema does not include a
propertieskey in the dictionary, causing theproperties = self.schema['properties']to fail.Defaulting properties to an empty dictionary to prevent exception in these cases without unintended side effects.