Propagate vendor extensions to collection/map container metadata in annotation reader#141
Open
jasper-vandemalle wants to merge 1 commit intodatanucleus:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
@Extensionannotations on collection or map fields, the vendor extensions are only applied to the member metadata (AbstractMemberMetaData) but not to the container metadata (CollectionMetaData/MapMetaData).The XML metadata handler doesn't have this problem since extensions nested inside
<collection>elements are applied to the collection metadata directly.The fix adds
contmd.addExtensions(extensions)inJDOAnnotationReader.processMemberAnnotations(), inside the existingif (contmd != null)block, so that vendor extensions reach both the container metadata and the member metadata.