fix(csi-s3/issue-340): improve volume unmount reliability#413
Open
MattPOlson wants to merge 1 commit intodatashim-io:masterfrom
Open
fix(csi-s3/issue-340): improve volume unmount reliability#413MattPOlson wants to merge 1 commit intodatashim-io:masterfrom
MattPOlson wants to merge 1 commit intodatashim-io:masterfrom
Conversation
- Make NodeUnpublishVolume idempotent by checking mount status before unmounting - Ensure fuse process cleanup occurs even if unmount operation fails - Improve error handling and logging during unmount operations This prevents errors when kubelet retries unmounting already-unmounted volumes and ensures orphaned fuse processes are properly cleaned up. The changes address two key issues: 1. nodeserver.go:168 - Added check to prevent errors on retry attempts 2. mounter.go:66 - Improved error handling to ensure fuse process cleanup happens regardless of unmount success Signed-off-by: Matt Olson <ucf.molson@gmail.com>
MattPOlson
force-pushed
the
fix/issue-340
branch
from
ee4f4e3 to
36addff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents errors when kubelet retries unmounting already-unmounted
volumes and ensures orphaned fuse processes are properly cleaned up.
The changes address two key issues: