Additional adjustments to the Admin classes#115
Conversation
…ization for all params, omit unspecified parameters from payload; add tests
…or astra/nonastra
…overloads as it's niche use
f87777b to
a79ae0d
Compare
|
@a-random-steve several changes but nothing too drastic here, IMO. |
a-random-steve
left a comment
There was a problem hiding this comment.
looks good once xmldoc warnings are fixed :)
|
Thank you @a-random-steve . I have resolved all warnings, I think, except four of them which the latest push to #120 addresses. |
toptobes
left a comment
There was a problem hiding this comment.
No real qualms. The only thing I'm unsure of is having updateDbKeyspace and waitForCompletion be top-level boolean params since they can be a bit confusing when not used with named method params.
It's probably out of scope for this PR, but just having something like BlockingCommandOptions which extends CommandOptions and the aforementioned options could be clearer to use.
I agree it's not the best for the caller @toptobes . There are many PRs in flight right now, so I'd prefer to file this change as a Pre-GA minor fix and merge this one as is, to avoid piling up scopes and extending the lifetime of each PR too much. (still scarred by things like 99 lol). WDYT? Edit: there, #127 created. |
Fixes #87 .
ASTRA_DB_ENVIRONMENTenvironment variable for tests (needed for some of the items on this PR)true) Slightly docs-impacting@sk-datastax pinging you because of some docs-impacts