Skip to content

Additional adjustments to the Admin classes#115

Merged
toptobes merged 9 commits intomainfrom
SL-issue87-admin-part2
Apr 8, 2026
Merged

Additional adjustments to the Admin classes#115
toptobes merged 9 commits intomainfrom
SL-issue87-admin-part2

Conversation

@sl-at-ibm
Copy link
Copy Markdown
Collaborator

@sl-at-ibm sl-at-ibm commented Mar 26, 2026

Fixes #87 .

  • Payload to "ListDatabases":
    • fix data types and serialization
    • respect parameters being optional in the payload (i.e. respect fields being omitted)
    • "starting_after" parameter made public (until DB list pagination is managed by the client)
  • management of ASTRA_DB_ENVIRONMENT environment variable for tests (needed for some of the items on this PR)
  • added a virtual property "Database.Keyspace" (useful for tests but also to client users)
  • Astra DB admin: removed in-client keyspace existence check in CreateKeyspace route
  • fixed Database's UpdateDBKeyspace implementation (was not working correctly)
    • Extended tests to comprehensively cover the intricacies here (to run manually. I did run them a lot)
  • Both DatabaseAdmin* classes' CreateKeyspace:
    • revise overloads: there were boolean/boolean ambiguities with UpdateDBKeyspace and WaitForCompletion Slightly breaking signatures
    • revise defaults: WaitForCompletion had inconsistent defaults across overloads (now always true) Slightly docs-impacting
    • re-order and re-arrange overloads for legibility (and alignment between the two classes)
    • introduce an IDictionary for replicationOptions in the DataAPI class (which affects overloads). Kept overloads minimal. Note: a general dictionary is expected (rationale: it's a very specific use case anyway).
  • Fix the hardcoded (prod) DevOps API url from some internal "GetDatabaseAdmin" methods of the AstraDatabasesAdmin class. These are used in the CreateDatabase path.
    • Improved the (manually-run) testing of CreateDatabase to verify. I ran these on PROD as well as DEV to confirm.

@sk-datastax pinging you because of some docs-impacts

@sl-at-ibm sl-at-ibm changed the title Additional adjustments to the Admin classes [Post-99] Additional adjustments to the Admin classes Mar 26, 2026
@sl-at-ibm sl-at-ibm requested a review from toptobes March 26, 2026 11:10
@sl-at-ibm sl-at-ibm force-pushed the SL-issue87-admin-part2 branch from f87777b to a79ae0d Compare March 31, 2026 14:13
@sl-at-ibm sl-at-ibm changed the title [Post-99] Additional adjustments to the Admin classes Additional adjustments to the Admin classes Mar 31, 2026
@sl-at-ibm
Copy link
Copy Markdown
Collaborator Author

@a-random-steve several changes but nothing too drastic here, IMO.

Copy link
Copy Markdown
Contributor

@a-random-steve a-random-steve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once xmldoc warnings are fixed :)

@sl-at-ibm
Copy link
Copy Markdown
Collaborator Author

Thank you @a-random-steve . I have resolved all warnings, I think, except four of them which the latest push to #120 addresses.

@sl-at-ibm sl-at-ibm requested a review from a-random-steve April 2, 2026 21:13
Copy link
Copy Markdown
Collaborator

@toptobes toptobes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real qualms. The only thing I'm unsure of is having updateDbKeyspace and waitForCompletion be top-level boolean params since they can be a bit confusing when not used with named method params.

It's probably out of scope for this PR, but just having something like BlockingCommandOptions which extends CommandOptions and the aforementioned options could be clearer to use.

@sl-at-ibm
Copy link
Copy Markdown
Collaborator Author

sl-at-ibm commented Apr 3, 2026

updateDbKeyspace and waitForCompletion be top-level boolean params

I agree it's not the best for the caller @toptobes . There are many PRs in flight right now, so I'd prefer to file this change as a Pre-GA minor fix and merge this one as is, to avoid piling up scopes and extending the lifetime of each PR too much. (still scarred by things like 99 lol). WDYT?

Edit: there, #127 created.

@toptobes toptobes merged commit 14d8dd0 into main Apr 8, 2026
2 checks passed
@toptobes toptobes deleted the SL-issue87-admin-part2 branch April 8, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leftover glitches in the admin classes

3 participants