Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves as a suggestion to work around a regression silently introduced on main.
(silent because the test was disabled on HCD and did not get caught).
So, a (sound, pre-GA) solution is offered for the current failure, but also a typed-read-path new problem is highlighted, which I think should be addressed pre-GA. In more detail:
Test_EmptyColumnValuestest for HCD. The test behaves identically on Astra/HCD. (note for the future: are there any other tests that are Astra-only for no reason?)Genres(I think it comes from the fact that untyped now returnsJsonElements. A broader typecast resolved the failing check and I think it's ok from a untyped perspective)set, but using a typed approach with a non-nullable HashSet for the field, should populate the row with an empty HashSet and not a null. Yet, the test shows one finds a Null there <--- would you agree this should be changed?