#98 Additional AllPairs overload, clean up FilterBuilder#124
Open
a-random-steve wants to merge 4 commits intodatastax:mainfrom
Open
#98 Additional AllPairs overload, clean up FilterBuilder#124a-random-steve wants to merge 4 commits intodatastax:mainfrom
a-random-steve wants to merge 4 commits intodatastax:mainfrom
Conversation
… how the subclasses worked to eliminate the need for all of the "new" strongly typed variants.
toptobes
reviewed
Apr 3, 2026
toptobes
reviewed
Apr 3, 2026
toptobes
reviewed
Apr 3, 2026
toptobes
reviewed
Apr 3, 2026
toptobes
reviewed
Apr 3, 2026
| { | ||
| return new Filter<T>(fieldName, FilterOperator.Size, size); | ||
| } | ||
| public TFilter Size(string fieldName, int size) |
Collaborator
There was a problem hiding this comment.
$size is for collections only
toptobes
reviewed
Apr 3, 2026
| /// <param name="expression">An expression that represents the map field for this filter</param> | ||
| /// <param name="pairs">The key-value pairs to check against</param> | ||
| /// <returns>The filter</returns> | ||
| public TFilter AllPairs<TKey, TValue>(Expression<Func<T, IDictionary<TKey, TValue>>> expression, IEnumerable<KeyValuePair<TKey, TValue>> pairs) |
Collaborator
There was a problem hiding this comment.
This is table-only, right? Or does this have a collection usage?
toptobes
reviewed
Apr 3, 2026
| { | ||
| return new Filter<T>(expression.GetMemberNameTree(), FilterOperator.Exists, true); | ||
| } | ||
| public TFilter Exists<TField>(Expression<Func<T, IEnumerable<TField>>> expression) |
Collaborator
There was a problem hiding this comment.
Exists is collection-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98 and #75.