test(e2e): fix flaky CA-secret race in gateway-accepted#215
Merged
Conversation
The gateway-accepted test created a cert-manager CA Certificate and immediately copied its secret into envoy-gateway-system, racing issuance. On slow runners the secret didn't exist yet, failing with "secrets <name> not found / no objects passed to apply" and flaking the suite. Assert the Certificate is Ready first. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ecv
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a flaky failure in the
gateway-acceptedchainsaw e2e test.Why
The
Create CAstep creates a cert-manager CACertificateand then immediately runs a script that copies the resulting secret intoenvoy-gateway-system— with no wait in between. cert-manager has to issue the self-signed CA and write the secret first; on a slow runner the copy runs too early and fails:→
exit status 1→ the suite fails. Confirmed flaky: the same branch produced both passing and failing runs on identical code.Fix
Add an
assertthat the CACertificateisReadybefore the copy script (cert-manager writes the secret before marking the cert Ready), making the step deterministic.Notes
🤖 Generated with Claude Code