Try to make CI faster#67
Merged
Merged
Conversation
This reverts commit 9078c52.
- Add .opam, Makefile, dune, dune-project to .gitattributes with eol=lf - Use dune-project instead of *.opam for cache key (source of truth)
Cram tests use shell commands that behave differently on Windows (echo, pipes, etc), causing test failures. The core functionality is still tested via Alcotest unit tests.
Two issues causing cram tests to fail on Windows: 1. .gitattributes: Add *.t and *.sh files to enforce LF line endings. Cram tests compare output literally, so CRLF vs LF mismatches would cause test failures. 2. cli/cli.ml: Set stdout to binary mode on Windows. By default, Windows text mode converts \n to \r\n on output, causing test output mismatches. Binary mode ensures consistent LF output across all platforms.
davesnx
force-pushed
the
make-ci-faster
branch
from
January 16, 2026 15:04
c4a9b5b to
0735716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.