Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
123 commits
Select commit Hold shift + click to select a range
d7f3133
feat: no global working path with asserts
bstefanuk Jan 14, 2025
a1375c7
fix: bad import statement
bstefanuk Jan 15, 2025
07cd30c
fix: different build_tmp dir in cmake than tensile
bstefanuk Jan 15, 2025
b5b0f49
fix: incorrect pathing in Tensile benchmarking
bstefanuk Jan 17, 2025
17aa51a
fix: string wrap paths for assert checks
bstefanuk Jan 17, 2025
33aea17
Merge branch 'develop' into remove-global-working-path
bstefanuk Jan 18, 2025
66c157d
fix: ensure all paths are built
bstefanuk Jan 18, 2025
c2e09c6
fix: missing global parameter warning
bstefanuk Jan 20, 2025
5faedfc
Merge branch 'develop' into remove-global-working-path
bstefanuk Jan 23, 2025
d3a11bc
fix: ensure library logic path is built
bstefanuk Jan 23, 2025
9517470
fix: client writer paths
bstefanuk Jan 23, 2025
4f73598
fix: use child path for client libraries
bstefanuk Jan 23, 2025
df28683
remove PrintTiming from global params
bstefanuk Jan 23, 2025
ea37c06
remove another assert
bstefanuk Jan 23, 2025
8d72b2b
restore PrintTiming
bstefanuk Jan 24, 2025
af18c2e
Merge branch 'develop' into remove-global-working-path
bstefanuk Jan 24, 2025
eab5145
fix: reviewer comments
bstefanuk Jan 28, 2025
5599a46
refactor: use env var for @timing decorator
bstefanuk Jan 24, 2025
54072cc
refactor: remove library print debug
bstefanuk Jan 24, 2025
4265e9c
refactor: remove exit after kernel gen option
bstefanuk Jan 24, 2025
08348e1
style: remove commented code
bstefanuk Jan 24, 2025
8c7b0a3
refactor: move common to a module
bstefanuk Jan 24, 2025
e745693
feat: remove 'CustomKernelDirectory' global param
bstefanuk Jan 28, 2025
a6080cf
Merge branch 'develop' into remove-global-working-path
bstefanuk Jan 29, 2025
20b514b
fix: amd clang version global param
bstefanuk Jan 29, 2025
6ef1f5c
Merge branch 'develop' into remove-global-working-path
bstefanuk Jan 30, 2025
1da3cbf
Merge branch 'develop' into remove-global-working-path
bstefanuk Jan 30, 2025
8390470
Merge branch 'remove-global-working-path' into move-common-to-module
bstefanuk Jan 31, 2025
884777b
fix: second pass on amd clang version
bstefanuk Jan 31, 2025
56ea8f7
Merge branch 'develop' into move-common-to-module
bstefanuk Feb 3, 2025
044fdf6
fix: imports for bolted on ops scripts
bstefanuk Feb 3, 2025
5ffa0a4
chore: remove safety asserts
bstefanuk Feb 4, 2025
94e4973
chore: create more separation in Common
bstefanuk Feb 5, 2025
8dc646a
fix: missing line at eof
bstefanuk Feb 5, 2025
364e4e5
fix: basic reviewer comments
bstefanuk Feb 7, 2025
92c13f3
chore: move global dependenct funcs to GlobalParameters.py
bstefanuk Feb 7, 2025
76d2579
fix: pass global params to splitArchs
bstefanuk Feb 7, 2025
57cb9af
style: don't format caps funcs
bstefanuk Feb 7, 2025
3d4ea71
fix: bad import
bstefanuk Feb 7, 2025
b5f8a63
Merge branch 'develop' into move-common-to-module
bstefanuk Feb 10, 2025
afec069
Add TensileLogic program to verify matrix instructions (#3)
bstefanuk Feb 10, 2025
2b4402e
Remove unused and static global parameters (#5)
bstefanuk Feb 11, 2025
dc7cf35
Update preferred search paths (#4)
bstefanuk Feb 11, 2025
cf7b74e
fix: remove files updated by precommit in merge
bstefanuk Feb 11, 2025
9de3e29
fix: remove log file
bstefanuk Feb 11, 2025
fc53bb1
Merge remote-tracking branch 'origin/develop' into move-common-to-module
davidd-amd Feb 11, 2025
8f48343
Copyright update
davidd-amd Feb 11, 2025
2ebb6ea
Remove short names from globalParameters
davidd-amd Feb 11, 2025
66c734b
Remove global params for kernel debugging
davidd-amd Feb 11, 2025
f64db43
Resolve tox failures
davidd-amd Feb 11, 2025
8e8ed08
Remove code from file and force generation globals
davidd-amd Feb 11, 2025
59a2bd6
Remove HipClangVersion
davidd-amd Feb 11, 2025
66b5db2
remove splitgsu and print rejection reason in kernel writers
davidd-amd Feb 11, 2025
d314777
Finish removing splitGSU and print rejection reason
davidd-amd Feb 12, 2025
549f5cb
feat: move capabilities to object
bstefanuk Feb 11, 2025
fc23660
fix: update capabilities table
bstefanuk Feb 13, 2025
21d99ba
fix: remove asm path from isa info
bstefanuk Feb 13, 2025
6689017
fix: more missing function arguments
bstefanuk Feb 13, 2025
27c8086
Merge branch 'develop' into global-removal-asm-caps
bstefanuk Feb 13, 2025
f6effac
Remove currentISA from globalParameters
davidd-amd Feb 13, 2025
5a9c59a
Merge branch 'develop' into code-gen-globals
davidd-amd Feb 14, 2025
af9f765
remove unused globalParrams reference
davidd-amd Feb 14, 2025
a42f800
Removes current isa usage
davidd-amd Feb 14, 2025
4ef1bb9
Serialization bug
davidd-amd Feb 15, 2025
208380b
Fix return from detect isa fxn
davidd-amd Feb 15, 2025
35a235f
Support cross compilation
davidd-amd Feb 15, 2025
10aee3b
remove arg
davidd-amd Feb 15, 2025
9a2409b
Merge remote-tracking branch 'braden/global-removal-asm-caps' into gl…
davidd-amd Feb 15, 2025
cd7f49c
Merge branch 'code-gen-globals' into global-mc
davidd-amd Feb 15, 2025
6b57924
Fix 942 test failures
davidd-amd Feb 16, 2025
0d9b126
Updates to toolchain to accomodate rocm version
davidd-amd Feb 16, 2025
13ad2e0
Merge branch 'code-gen-globals' into global-mc
davidd-amd Feb 16, 2025
f994830
First pass at removing globals from SolutionStructs.py
davidd-amd Feb 17, 2025
4abe998
Fix broken tests
davidd-amd Feb 17, 2025
b99eebe
Completely remove globalParams from solutionstructs
davidd-amd Feb 17, 2025
17df3b2
Merge remote-tracking branch 'origin/develop' into global-mc
davidd-amd Feb 17, 2025
10605c6
942 tests
davidd-amd Feb 17, 2025
9846746
Missing arg
davidd-amd Feb 17, 2025
ef0991f
Separate validParameters
davidd-amd Feb 17, 2025
81dfb94
Missing file
davidd-amd Feb 17, 2025
02a0f2f
add ValidParameters to common module
davidd-amd Feb 17, 2025
90b5e8f
Isolated naming functions
davidd-amd Feb 17, 2025
4382f49
Fix tox tests
davidd-amd Feb 17, 2025
7f6f16c
Move minkforgsu to Module local constant
davidd-amd Feb 17, 2025
6f57df5
missing file
davidd-amd Feb 17, 2025
371011e
Only compute kernel base name once
davidd-amd Feb 17, 2025
029a0b4
Factor out ProblemType to avoid circular import
davidd-amd Feb 18, 2025
641eeb9
Break dependency on printExit
davidd-amd Feb 18, 2025
c1cc39e
Ordering
davidd-amd Feb 18, 2025
061ffb6
Fix missing state
davidd-amd Feb 18, 2025
6da643a
fix logic
davidd-amd Feb 18, 2025
1b2967c
Fix build errors
davidd-amd Feb 19, 2025
6bea1a0
Merge remote-tracking branch 'origin/develop' into global-mc
davidd-amd Feb 20, 2025
9a2c213
Fix if test
davidd-amd Feb 21, 2025
7a97872
Need to use all kernels when building co files
davidd-amd Feb 25, 2025
a2541dc
refactor: valid parameter checks
bstefanuk Feb 19, 2025
140b74e
refactor: move solution structs to module
bstefanuk Feb 20, 2025
972426d
test: custom kernel config 9-4 conversion
bstefanuk Feb 26, 2025
39fffa3
draft: continue migrating custom kernel MI entries
bstefanuk Feb 27, 2025
70054c3
draft: custom TensileLogic for custom kernel manipulation
bstefanuk Feb 27, 2025
a4e3dd5
feat: use mi parameters in custom kernels
bstefanuk Feb 27, 2025
5576c7e
draft: TCL is building
bstefanuk Feb 28, 2025
7670dd1
draft: printing and debugging, mostly
bstefanuk Feb 28, 2025
f7e41d4
draft: more printing and debugging tox tests
bstefanuk Feb 28, 2025
e8d5b99
Merge branch 'develop' into remove-valid-mi-NEW
bstefanuk Feb 28, 2025
43b094b
fix: stubborn client bug
bstefanuk Mar 3, 2025
8e4707c
refactor: problem type into solution struct
bstefanuk Mar 3, 2025
9e9cd8b
style: remove debug printing
bstefanuk Mar 3, 2025
c4a2956
fix: problem type import and more debugging
bstefanuk Mar 3, 2025
08d9a9c
fix: bad import for elineno
bstefanuk Mar 3, 2025
de315b2
fix: 9-item to 4-item mapping for custom kernel DTVA
bstefanuk Mar 3, 2025
5a59fec
fix: tensile logic check
bstefanuk Mar 3, 2025
0fbd45a
fix: only convert 9-item MI in BenchmarkProblems
bstefanuk Mar 3, 2025
4114e28
fix: some Tensile Solutions don't have a wavefront size
bstefanuk Mar 3, 2025
4e8c919
fix: some Tensile Solutions don't have a work group
bstefanuk Mar 3, 2025
58ac28d
fix: add wavefront size to missing custom kernels
bstefanuk Mar 3, 2025
a8a636c
fix: debug work group
bstefanuk Mar 3, 2025
d2286f2
fix: restore wavefront size and work group
bstefanuk Mar 3, 2025
16e9c5b
Revert "fix: debug work group"
bstefanuk Mar 3, 2025
0e827dd
fix: make work group optional but not wavefront sz
bstefanuk Mar 3, 2025
2a75b57
fix: add wavefront size to missing custom kernels
bstefanuk Mar 3, 2025
9635690
BOOKMARK: delete MatrrixInstructions from validParameters
bstefanuk Mar 3, 2025
266e9b8
just set MatrixInstruction to -1 instead
bstefanuk Mar 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/amd_detail/rocblaslt/include/Debug.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*
* MIT License
*
* Copyright (C) 2022-2024 Advanced Micro Devices, Inc. All rights reserved.
* Copyright (C) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down
6 changes: 3 additions & 3 deletions library/src/amd_detail/rocblaslt/include/rocblaslt-types.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*
* MIT License
*
* Copyright (C) 2022-2024 Advanced Micro Devices, Inc.
* Copyright (C) 2022-2025 Advanced Micro Devices, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -389,8 +389,8 @@ typedef struct __attribute__((packed, aligned(8))) _rocblaslt_matmul_algo
typedef struct _rocblaslt_matmul_algo{
#ifdef __cplusplus
uint8_t data[8] = {0}; // must match hipblasLtMatmulAlgo_t layout
bool fallback = false; //
uint8_t data_pad[7] = {0}; // has uint8_t data[16]
bool fallback = false; //
uint8_t data_pad[7] = {0}; // has uint8_t data[16]
size_t max_workspace_bytes = 0;
#else
uint8_t data[8];
Expand Down
2 changes: 1 addition & 1 deletion library/src/amd_detail/rocblaslt/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ string(REGEX MATCH "([0-9]+\\.[0-9]+\\.[0-9]+)" GCC_VERSION "${GCC_OUTPUT}")
message(STATUS "Extracted GCC Version: ${GCC_VERSION}")

# Compare GCC version and set the flag conditionally if it's 7.5.0 or less
if(${GCC_VERSION} VERSION_LESS "7.6.0")
if(${GCC_VERSION} VERSION_LESS "7.6.0")
# Apply -ftemplate-depth=2048 to tensile_host.cpp if GCC_VERSION is less than 7.6.0 to avoid template recursion
set_source_files_properties(src/amd_detail/rocblaslt/src/tensile_host.cpp PROPERTIES COMPILE_FLAGS "-ftemplate-depth=2048")
endif()
Expand Down
4 changes: 2 additions & 2 deletions library/src/amd_detail/rocblaslt/src/Debug.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*
* MIT License
*
* Copyright (C) 2022-2024 Advanced Micro Devices, Inc. All rights reserved.
* Copyright (C) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -60,7 +60,7 @@ namespace rocblaslt
#ifndef HIPBLASLT_ENABLE_MARKER
if(m_printMarker)
printf("HIPBLASLT_ENABLE_MARKER is not defined. Please rebuild with -DHIPBLASLT_ENABLE_MARKER=ON\n");
#endif
#endif
}

const char *hipblaslt_preload = std::getenv("HIPBLASLT_PRELOAD_KERNELS");
Expand Down
2 changes: 1 addition & 1 deletion library/src/amd_detail/rocblaslt/src/include/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*
* MIT License
*
* Copyright (C) 2022 Advanced Micro Devices, Inc.
* Copyright (C) 2022-2025 Advanced Micro Devices, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down
2 changes: 1 addition & 1 deletion library/src/amd_detail/rocblaslt/src/include/utility.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*
* MIT License
*
* Copyright (C) 2022-2024 Advanced Micro Devices, Inc.
* Copyright (C) 2022-2025 Advanced Micro Devices, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down
2 changes: 1 addition & 1 deletion tensilelite/Tensile/Activation.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
TensileInstructions
from .TensileInstructions.Enums import *
from .TensileInstructions.Instructions import *
from .Common import printExit, printWarning
from Tensile.Common.Utilities import printExit, printWarning

from dataclasses import dataclass, field

Expand Down
Loading