Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the ui already contains reload-buttons to only reload the data, however if the user tries to reload the whole page, he get an empty page with the message "not found", since the backend is no configured to redirect the urls to index.html
this problem is not present when developing with
yarn start, since all request are handled by yarn, which correctly redirects themi did not find a a way to configure javalin to redirect unknown traffic to index.html, therefore i added a redirect for each path
Alternatives could be to change the urls to be easier to differentiate or to switch to a HashRouter in the frontend