Avoid writing uninitialized stack memory into INFO.ind and LEARN.ind#1
Open
bmwiedemann wants to merge 1 commit intodavidsd:masterfrom
Open
Avoid writing uninitialized stack memory into INFO.ind and LEARN.ind#1bmwiedemann wants to merge 1 commit intodavidsd:masterfrom
bmwiedemann wants to merge 1 commit intodavidsd:masterfrom
Conversation
(probably required because compilers do padding on structs) in order to make package builds reproducible See https://reproducible-builds.org/ for why this is good
Owner
|
Thanks for the pull request! I should say that 1) I've had no communication with the upstream LiE developers, 2) this repository also has not been maintained in a while, and 3) the copy of LiE contained herein has been somewhat modified. So I'd recommend trying elsewhere if you want to get things merged upstream. |
Author
|
I don't know where 'elsewhere' would be, so I would just push it into openSUSE then.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(probably required because compilers do padding on structs)
in order to make package builds reproducible
See https://reproducible-builds.org/ for why this is good
I could not find a way to contribute this patch to upstream LiE,
so I'm sending it here in the hope that it will be useful
and eventually find its way to upstream.
Also tracked at https://bugzilla.opensuse.org/show_bug.cgi?id=1061220