Add CMake support (Do not merge)#223
Draft
bharathr98 wants to merge 24 commits intodavidsd:masterfrom
Draft
Conversation
Copied over wscript, @vasdommes had already made a few changes from waf to cmake. Cleaned up, and added more TODOs
Two things need to be fixed - 1) Make sure that MPFR_REQUIRED is set properly and 2) Resolve missing MPFR_VERSION in the case where find_package is not used
… needing libarchive-dev
…rchive. Removed few refs to local paths
…, plus additional Boost components. Integration tests pending
Avoids issue with boost/stacktrace when building on macOS. See boostorg/stacktrace#88 and comments therein.
The Docker image bootstrapcollaboration/elemental:master does not come with ElementalConfig.cmake, thus custom solution needed
CBLAS commented out because it is not necessary for the current set of build sources. Will be required later, together with FLINT, for the implementation of Chinese remainder theorem
Bring branch up to date with upstream/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #74
Currently this branch does not faithfully build tests. The last commit where everything apart from tests works is 9baff5e.
Here's a list of things to fix before merging
When building Catch2, CMake is unable to see where mpicxx is and thus gives an errorBuilding with Catch2 additionally requires using-pthreadcompiler flag, which seems to mess up everything upstream--platform=linux/amd64to build properly on Mx Macs