patch for workaround for compatability with XCode9 + node 8.6.0#27
Open
DonaldFoss wants to merge 1 commit intodavidtsai:masterfrom
Open
patch for workaround for compatability with XCode9 + node 8.6.0#27DonaldFoss wants to merge 1 commit intodavidtsai:masterfrom
DonaldFoss wants to merge 1 commit intodavidtsai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.0.5 of this module will not compile correctly with XCode 9 installed, which is the default for Mac OSX High Sierra. This workaround is successfully being used in other projects, for example Apache Arrow. I have tested it locally using Mac OSX Sierra with XCode 9 and node 8.6.0.
Please merge this at your earliest convenience. Every time I do an install of package.json, it pulls this from npmjs.org and I must manually find the cached version and edit the file.
Note that I have only tested this on a Mac with XCode 9. I have not tested it on any other OS or compiler version. Perhaps these 3 lines could be in an #ifdef in the mac/x64 specifig config files.