Skip to content
This repository was archived by the owner on Jun 9, 2021. It is now read-only.

Fix cases when hash is missing or link is external#135

Open
typeofweb wants to merge 1 commit into
davist11:masterfrom
typeofweb:master
Open

Fix cases when hash is missing or link is external#135
typeofweb wants to merge 1 commit into
davist11:masterfrom
typeofweb:master

Conversation

@typeofweb

Copy link
Copy Markdown

Fixes #120 as well.

@rajeebbanstola

Copy link
Copy Markdown

Hi @davist11, Is it possible for you to merge this? Thank you!

@typeofweb

Copy link
Copy Markdown
Author

@RajeebTheGreat I think this repository is not maintained anymore, but feel free to use my fork where this issue is fixed: https://github.com/mmiszy/jQuery-One-Page-Nav

@davist11

Copy link
Copy Markdown
Owner

This is the entire point of the filter option

@typeofweb

Copy link
Copy Markdown
Author

How the filter option works remains unchanged, I only fixed a bug in it.
Moreover I fixed #120 and took care of the scenario where link might be external.

@davist11

davist11 commented Jan 26, 2017

Copy link
Copy Markdown
Owner

But what if someone is forced to use absolute URLs in their links?

@typeofweb

typeofweb commented Jan 26, 2017

Copy link
Copy Markdown
Author

I'm not sure what you mean by that?
Clicking on an external link navigates to another website.

This has nothing to do with relative/absolute URLs. Absolute URLs work just fine as long as they're internal, not external.

For example, imagine your website address is http://davist11.co/. Any of the following hrefs are considered internal:

  • /
  • dsadsa
  • /dsadsa/dsadsa
  • abc/def
  • http://davist11.co/
  • http://davist11.co/abc
  • http://davist11.co/das/das/das/

While these are considered external:

  • http://google.com/
  • http://facebook.com/friends/
  • http://blog.davist11.com/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'split' of undefined

3 participants