Patch 6.2 Updates#23
Open
Fierydemise wants to merge 297 commits into
Open
Conversation
- fix base run_through damage calc
-trait ranking -disabled get_talents_ranking override -extracted energy cap calcuation -added support for vigor -fixed combat potency multiplier -remove relentless strike calcs
-Add nightstalker and MoS damage modifiers -Fix evis overcounting on convergence loop -Weaponmaster support
- asn script and model first pass - dispatched dispatch
-Fix demon_kiss trait to demons_kiss -Traits will now properly rank for binary traits when selected
…/ShadowCraft-Engine into WaveFunctionP-outlawscriptupdate
- removed execute model for asn
- modified spec test scripts to pprint talent ranking
- added some trinkets - ignore test output
-Outlaw model WIP
Fix finality eviscerate handling
SnD only outlaw model, still debugging RtB
-Likely overcounting somewhere, but runs
Soul of the Shadowblade The Empty Crown The First of the Dead
Patch 7.2.5
Better throw an exception to say the model is not working correctly than having it return outdated calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.2 patch note/datamining changes implemented. Using datamined changes when conflict between notes and mining.
All set bonuses implemented.
Citadel trinkets implemented, checks needed on spec trinket interaction with SR and mirror trinket damage modifier inheritance.
Still missing: Legendary Ring support