feat: Support for running simply sequentially without worker threads#4
Merged
feat: Support for running simply sequentially without worker threads#4
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for running the Ractor::Wrapper sequentially without worker threads, changing the default behavior from single-threaded to sequential execution mode.
- Changes the default
threadsparameter from 1 to 0, disabling worker threads by default - Implements sequential execution logic that handles method calls directly in the main loop when threads are disabled
- Expands test coverage to verify all functionality works in both sequential (threads: 0) and threaded (threads: 2) modes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/ractor/wrapper.rb | Implements sequential execution mode, updates default threads parameter to 0, adds port closing for resource cleanup, changes send to __send__ for more robust method invocation, and updates documentation to reflect new threading model |
| test/test_wrapper.rb | Restructures tests to run with both sequential and threaded configurations, ensuring comprehensive coverage of all wrapper behaviors in both modes |
| README.md | Updates documentation to clarify threading model caveats and align with code changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.