Skip to content

Fix for composer argument #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmorrical-ICC wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for composer argument #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ services:

php:
environment:
COMPOSER_AUTH: ${COMPOSER_AUTH}
Copy link
Owner

@dbergunder dbergunder May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am passing the COMPOSER_AUTH as an env flag here: https://github.com/dbergunder/docker-php-boilerplate/blob/master/.env.dist#L7 per the docs: https://getcomposer.org/doc/03-cli.md#composer-auth

Explanation:
https://www.previousnext.com.au/blog/managing-composer-github-access-personal-access-tokens#what-about-automated-testing-environments

Copy link
Author

@bmorrical-ICC bmorrical-ICC May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll try the boilerplate from scratch to test this... I am getting the following unless it's in the args block, but maybe a difference in Docker config here we are dealing with.

Screen Shot 2020-05-10 at 10 08 48 PM

Copy link
Owner

@dbergunder dbergunder May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your token is malformed, are you sure it's all on one line as a json string? You know what, this might be from a poor example in the env.dist file. Try without surrounding the json object with quotes:
{"github-oauth":{"github.com":""}}

APP_ENV: ${APP_ENV}
APP_SECRET: ${APP_SECRET}
build:
context: ./docker/php
args:
TIMEZONE: ${TIMEZONE}
COMPOSER_AUTH: ${COMPOSER_AUTH}
restart: on-failure
volumes:
- ./app:/var/www/html
Expand Down