gsoc26: Manifest Replay for download, delete, and deploy (#65) - #81
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Integer-Ctrl
left a comment
There was a problem hiding this comment.
Usability tests did not reveal any bugs
…a deploy, clean error output for deploy
|
Apart from the review comment fixes, the latest commit also contains a small improvement to manifest summary: when an operation failed, the summary now also shows the actual error message (the "cause"), not just "Status: failed" — so users don't have to open the raw manifest file to see why something failed. Also included two small, unrelated-to-replay fixes, to include here rather than as separate issues since they're small and genuinely affect users:
|
Pull Request
Description
Implements
databusclient manifest replay <path>for all three commands — download, delete, and deploy.replayParams(compression, format conversion, graph-name, base-uri, checksum validation). Credentials (--vault-token/--databus-key) and--localdirare never read from the manifest — always supplied fresh at replay time.y/yesconfirmation by default before deleting, per mentor discussion.--force(CLI-only, never stored in the manifest) skips the prompt for scripted/CI use.dry_runis read automatically from whatever was recorded in the originaldelete --dry-run --manifest ...run; a replay-time--dry-runoverride can additionally force a preview.create_dataset()inputs directly from the stored data. WebDAV/Nextcloud mode is explicitly not supported for replay, since locally uploaded files may no longer exist at their original paths by replay time.All three replay paths raise a clean, actionable error (never a raw traceback) for: missing/corrupted manifest files, missing required fields, missing credentials, and unsupported commands.
Related Issues
#65
Type of change
Checklist:
poetry run pytest- all tests passedpoetry run ruff check- no linting errors