Open
Conversation
Contributor
|
This probably wants a rebase / force-push for updated CI? |
Author
Thank you, done. Travis now looks happy. |
Contributor
|
Could you rebase it rather than that merge commit? :-) |
When we create a foreign key constraint for MySQL we also create an
index, if there is not already an index beginning with the field in
question. UNIQUEness constaint are implemented by indices, and so we
should also skip adding an index if one already exists.
To avoid changing existing fully-working schemas, this change only skips
index creation if one with the same name already exists. This case
currently fails with a duplicate key error in MySQL, eg.,
ERROR 1061 (42000): Duplicate key name 'foo'
davel
force-pushed
the
davel/clashing-index-names
branch
from
5a5abaf to
5a278bb
Compare
Author
Now rebased against current master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve a problem in which a
CREATE TABLEis generated that MySQL rejects with a duplicate key name error.When we create a foreign key constraint for MySQL we also create an index if there is not already an index beginning with the field in question. UNIQUEness constraints are implemented by indices, and so we can skip adding an index if one already exists.
To avoid changing existing working schemas, this change only skips index creation if one with the same name already exists. This case currently fails with a duplicate key error in MySQL, eg.,
ERROR 1061 (42000): Duplicate key name 'foo'