Open
Conversation
rabbiveesh
requested changes
Oct 5, 2025
Contributor
rabbiveesh
left a comment
rabbiveesh
left a comment
There was a problem hiding this comment.
by and large looking good, tho i think the drop constraint fix should go in a separate PR (b/c i don't know mysql well enough to see what was originally wrong; i don't want that to hold up the generated stuff)
dn1lk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there!
With this pull request, I added support for generated fields and also changed the generation of drop constraints in MySQL according to the documentation.
This is my first pull request for an open source project - if I do anything wrong, I'm ready to correct it =)