Add Parser::DBI::PostgreSQL support for proc / trigger#195
Open
nrdvana wants to merge 2 commits intodbsrgits:masterfrom
Open
Add Parser::DBI::PostgreSQL support for proc / trigger#195nrdvana wants to merge 2 commits intodbsrgits:masterfrom
nrdvana wants to merge 2 commits intodbsrgits:masterfrom
Conversation
nrdvana
force-pushed
the
dbi_postgresql_procs_triggers
branch
from
857b2e9 to
db1389a
Compare
This adds support to the DBI parser for Postgres to read the user-defined stored procedures and triggers from the public namespace. It has been tested on only two versions of postgres so far...
nrdvana
force-pushed
the
dbi_postgresql_procs_triggers
branch
from
db1389a to
983be4a
Compare
KES777
reviewed
Dec 5, 2025
| / | ||
| ) or die "Can't prepare: $@"; | ||
|
|
||
| my $trigger_select = $dbh->prepare(<<SQL) or die "Can't prepare trigger query: $@"; |
Contributor
There was a problem hiding this comment.
I would like to see the description what is the result of these two blocks of code: 'trigger_select' and 'procedure_select'. Eg. this block of code selects triggers and procedures from XXX which we can access later programmatically using YYY
Contributor
Author
There was a problem hiding this comment.
Not entirely sure what I can say there... the code itself just prepares the query and follows the style of the code above it. I could comment more on what each field means, but the fields are generally matching the names used on the Trigger and Procedure objects.
Contributor
There was a problem hiding this comment.
Just general comment what this block does and how we can use/access those results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to the DBI parser for Postgres to read the user-defined stored procedures and triggers from the public namespace.
It has been tested on only two versions of postgres so far...
but I've been using it in production for quite a while.
This is independent of #182 which adds support to the SQL parser, but seems to omit the DBI parser.