Postgres producer ALTER COLUMN: specify USING for datatype change#196
Open
nrdvana wants to merge 1 commit intodbsrgits:masterfrom
Open
Postgres producer ALTER COLUMN: specify USING for datatype change#196nrdvana wants to merge 1 commit intodbsrgits:masterfrom
nrdvana wants to merge 1 commit intodbsrgits:masterfrom
Conversation
nrdvana
force-pushed
the
postgresql_coltype_change_using
branch
from
cd9af18 to
7248f4a
Compare
Postgres 8 and later require a `USING expression` clause when changing the type of a column in a potentially lossy manner, such as from C<text> to C<numeric>. This change adds an automatic `USING (colname::datatype)` suffix any time the data type has changed, which should be a safe default. It is also conditioned on the version of Postgres, but also makes it the default in absence of a version, since Pg 8 is so old.
nrdvana
force-pushed
the
postgresql_coltype_change_using
branch
from
7248f4a to
3441853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres 8 and later require a C<< USING expression >> clause when changing the type of a column in a potentially lossy manner, such as from C to C.
This change adds an automatic "USING (colname::datatype)" suffix any time the data type has changed, which should be a safe default. It is also conditioned on the version of Postgres, but also makes it the default in absence of a version, since Pg 8 is so old.