feat: display event_time in model details panel#584
Open
psaikaushik wants to merge 1 commit intodbt-labs:mainfrom
Open
feat: display event_time in model details panel#584psaikaushik wants to merge 1 commit intodbt-labs:mainfrom
event_time in model details panel#584psaikaushik wants to merge 1 commit intodbt-labs:mainfrom
Conversation
Add event_time to the model details panel so developers working with microbatch models can see whether event_time is configured directly in the docs UI. The value is read from node.config.event_time in the manifest and only displayed when configured (non-null). Closes dbt-labs#583 Ref: dbt-labs/dbt-core#12800
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display the
event_timeconfiguration in the model details panel of the dbt docs UI.Closes #583
Ref: dbt-labs/dbt-core#12800
Problem
Developers working with microbatch models need to verify that
event_timeis configured on a model and its parents. Currently, they have to manually check both the YAML config and the code — the docs UI doesn't surface this information even though it's already present in the manifest atnode.config.event_time.Solution
Add an "Event Time" row to the model details panel in
table_details.js, following the same pattern as other config-derived properties (Owner, Language, Contract, etc.).The change:
event_timefrommodel.config.event_timegetBaseStats()detail list_.filterremoves entries withundefinedvalues)Code change (3 lines added)
How it looks
When
event_timeis configured on a model, the details panel will show:When
event_timeis not configured, the row is hidden (same behavior as Version, Access, etc.).Checks
table_details.jsmodifiedevent_timeis not configured (graceful degradation)