refactor: switch to camino for UTF-8 path handling
#385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codebase now uses `camino::Utf8Path` and `camino::Utf8PathBuf` instead of the standard library's `Path` and `PathBuf`. This ensures that paths handled by the application are valid UTF-8, which simplifies string conversions and improves interoperability with other crates and CLI output. Affected crates include `jp_attachment` and its implementations, as well as the `jp_cli` crate. Dev-dependencies have also been updated to use `camino-tempfile` for testing. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
JeanMertz
force-pushed
the
improve-tool-inquery49
branch
from
5e39620 to
fd5c3fe
Compare
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase now uses
camino::Utf8Pathandcamino::Utf8PathBufinstead of the standard library'sPathandPathBuf. This ensures that paths handled by the application are valid UTF-8, which simplifies string conversions and improves interoperability with other crates and CLI output.Affected crates include
jp_attachmentand its implementations, as well as thejp_clicrate. Dev-dependencies have also been updated to usecamino-tempfilefor testing.