enhance(config): allow boolean and numeric values for styles #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can now use booleans and numbers for specific configuration fields, providing a more concise way to configure the assistant's behavior. For instance, `inline_results` now accepts `true` (full), `false` (off), or a number to specify line truncation. Similarly, `link_style` fields now accept `true` for full links and `false` to disable them. This change also renames the `is_default` property to `discard_when_merged` within `MergeableString` and `MergeableVec`. This new name more accurately describes the property's role: ensuring that initial "default" configurations are completely replaced when a user provides their own settings, regardless of the chosen merge strategy. Finally, `serde-untagged` has been added to the workspace dependencies, to allow for better error messages when deserializing untagged enums. This has not been applied to all enums, but will be done in a future commit. Signed-off-by: Jean Mertz <git@jeanmertz.com>
JeanMertz
force-pushed
the
improve-tool-inquery51
branch
from
5577b3d to
dea126c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now use booleans and numbers for specific configuration fields, providing a more concise way to configure the assistant's behavior. For instance,
inline_resultsnow acceptstrue(full),false(off), or a number to specify line truncation. Similarly,link_stylefields now accepttruefor full links andfalseto disable them.This change also renames the
is_defaultproperty todiscard_when_mergedwithinMergeableStringandMergeableVec. This new name more accurately describes the property's role: ensuring that initial "default" configurations are completely replaced when a user provides their own settings, regardless of the chosen merge strategy.Finally,
serde-untaggedhas been added to the workspace dependencies, to allow for better error messages when deserializing untagged enums. This has not been applied to all enums, but will be done in a future commit.