Tolerate unparseable mod payloads in load_payloads()#31
Open
bradyccox wants to merge 1 commit into
Open
Conversation
load_payloads() catches SyntaxError but lets ValueError propagate. Some third-party mod payload Lua files (e.g. the CJS Super Hornet v2.4) use local variable names as table indices, which the Lua parser cannot represent and reports as a ValueError. A single such file currently aborts payload loading for every aircraft. Skip the offending file with a warning, matching the existing SyntaxError-tolerant behavior, so one malformed mod payload no longer breaks loadouts for the whole install. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FlyingType.load_payloads()catchesSyntaxErrorbut letsValueErrorpropagate. Some third-party mod payload Lua files (e.g. the CJS Super Hornet v2.4) use local variable names as table indices ([OBL],[JML], …), which the Lua parser can't represent —lua.loads()raisesValueError("could not convert string to float: ''"). A single such file currently aborts payload loading for every aircraft in the install.Fix
Skip the offending file with a warning, mirroring the existing
SyntaxError-tolerant path, so one malformed mod payload no longer breaks loadouts for the whole install.Verified that
lua.loads()raises exactlyValueErroron local-variable table indices.🤖 Generated with Claude Code