fix: jig-gradle-pluginをconfiguration cacheに対応#1070
Merged
Conversation
JigReportsTaskの@TaskAction内でgetProject()を呼び出していたため、 configuration cache有効時にタスク実行時にProject参照できずエラーになっていた。 - JigReportsTaskをabstract化しGradle managed propertyを導入 - すべてのProject参照をJigGradlePlugin.apply()のconfiguration phaseに集約 - JigConfigからProject依存メソッドを除去 - GradleProjectに依存プロジェクト含む全パス取得メソッドを追加 - configuration cache対応のFunctionalTestを追加 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> AGENT: Claude
haljik
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> AGENT: Claude
ConfigurableFileCollection.from(Provider)のProviderがProjectをキャプチャしていたため、 Gradle 8.14.3のconfiguration cacheでデシリアライズ時にnull arrayエラーが発生していた。 Providerを使わずconfiguration phaseで直接ファイルパスを解決するように変更。 AGENT: Claude
- JigConfigからロジック移動後に残っていたdocumentTypes(), documentTypesToExclude(), documentTypesToInclude(), propertiesText()を削除 - outputDirectoryとjavaPluginAppliedのProviderがprojectをキャプチャしていたのを configuration phaseで直接解決するように変更し、configuration cache安全性を向上 AGENT: Claude
- JigConfigから未使用のoutputOmitPrefixフィールドとアクセサを削除 - @DisableCachingByDefaultの理由文を@OutputDirectoryの存在と矛盾しない表現に修正 - Collectors.toSet()をstatic importに統一 AGENT: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JigReportsTaskの@TaskAction内でgetProject()を呼び出していたため、 configuration cache有効時にタスク実行時にProject参照できずエラーになっていた。
fix #1069
AGENT: Claude