Upgrade the third-party library version and fix unit test error#13
Open
daedalus2022 wants to merge 6 commits intoddimaria:masterfrom
Open
Upgrade the third-party library version and fix unit test error#13daedalus2022 wants to merge 6 commits intoddimaria:masterfrom
daedalus2022 wants to merge 6 commits intoddimaria:masterfrom
Conversation
ddimaria
reviewed
Dec 28, 2023
src/server.rs
Outdated
| .wrap(Cors::new().supports_credentials().finish()) | ||
| .wrap(Logger::default()) | ||
| .wrap(get_identity_service()) | ||
| // .wrap(Cors::new().supports_credentials().finish()) |
ddimaria
reviewed
Dec 28, 2023
|
|
||
| .configure(routes) | ||
| }); | ||
| }).workers(2); |
ddimaria
reviewed
Dec 28, 2023
| use crate::errors::ApiError; | ||
|
|
||
|
|
||
| pub static SECRET_KEY: Lazy<String> = |
Owner
There was a problem hiding this comment.
It might be best to fail if SECRET_KEY is absent.
ddimaria
reviewed
Dec 28, 2023
| pub static SECRET_KEY: Lazy<String> = | ||
| Lazy::new(|| std::env::var("SECRET_KEY").unwrap_or_else(|_| "0123".repeat(16))); | ||
|
|
||
| const _SALT: &[u8] = b"supersecuresalt"; |
Owner
There was a problem hiding this comment.
For the underscored variable here and the functions below, either remove or add comments as to why they ignored.
Owner
|
Thanks for the PR 🙏 Can you also update the README with relevant info (actix version, API updates, ...etc.)? |
added 2 commits
December 31, 2023 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.