Update CUDA extensions for newer PyTorch#27
Open
relh wants to merge 1 commit into
Open
Conversation
relh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newer PyTorch/CUDA builds no longer expose the old THC runtime APIs used by these CUDA extensions. That makes the ROIAlign, ROIPool, and NMS CUDA code harder or impossible to build on newer environments.
This PR moves the extension code toward modern ATen/C10 CUDA APIs. It replaces
THCudaCheckwith AT/C10 CUDA checks, uses the C10 CUDA caching allocator for the NMS mask allocation, and adds shared helper definitions needed by the ROI kernels.Verification