Conversation
This commit fix 2 failing tests that expect an exception to be raise if non integer values are used as attributes for the GRayPixel constructor. The expected behaviour is to only be able to create new pixels using the proper integer type.
both operations should return the expected result for the given example. Problem was the position of the intenral value matrix. This change also removes some deprecated/unused or imcomplete tests.
Just updated the test_lighten_operation_returns_correct_result parameters to maintain consistency with the darken "mirror" test.
this change was missing in a previous commit. The internal matrix refers a desired x,y pixel as a y,x coordinate in the value matrix. This change fixes the previous behaviour(using the x, y coordinate) to correctly fetch data in a given position.
The CodeClimate reporter need either to generate the report or to have a location set to fetch the desired report. This change updates the script to generate the coverage.py report as a XML and pass that location to the CC reporter.
The main.py entrypoing had some flake8 warnings. That said, it should be deprecated soon. BREAKING CHANGE: main.py will no longer be update and soon to be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the current failing tests, and overall get the CI/CD pipeline working properly.