Conversation
Walkthrough피드백 타이머의 초기화 로직을 페이지 수준에서 훅 수준으로 이동했습니다. 페이지의 마운트 시점에 타이머 상태를 설정하는 useEffect를 제거하고, 훅 내부에서 INITIAL_TIME을 0으로 고정하여 초기화 및 리셋 동작을 일관되게 처리합니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
i-meant-to-be
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
closed #398
📝 작업 내용
피드백 타이머 초기화 시 0분 0초로 변경
2025-11-13.2.19.36.mov
FeedbackTimerPage에서 선언되어있던 불필요한 useEffect제거
기존 defaultTime과 time의 초기 세팅을 하는 useEffect를 useFeedbackTimer에서 초기상태로 변경하였습니다.
🏞️ 스크린샷 (선택)
없음
🗣️ 리뷰 요구사항 (선택)
없음
Summary by CodeRabbit
릴리스 노트