fix: parse numeric environment variables to correct types#1886
Open
LautaroPetaccio wants to merge 2 commits into
Open
fix: parse numeric environment variables to correct types#1886LautaroPetaccio wants to merge 2 commits into
LautaroPetaccio wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several numeric environment variables were stored as strings when set via
process.env, but as numbers when using the default value. Consumers read them withgetConfig<number>(...), which silently receives a string. JavaScript coercion often makes this work, but it causes incorrect behavior in strict comparisons and library APIs that expect numbers.Changes in
Environment.ts:FOLDER_MIGRATION_MAX_CONCURRENCYNumber(...)with fallbackHTTP_SERVER_PORTNumber(...)with fallbackUPDATE_FROM_DAO_INTERVALms(... ?? '30m')to parse duration stringsDEPLOYMENTS_DEFAULT_RATE_LIMIT_MAXNumber(...)with fallbackPSQL_PORTNumber(...)with fallbackENTITIES_CACHE_SIZENumber(...)with fallbackDEPLOYMENT_RATE_LIMIT_MAXper-entityparseInt(value!, 10)replacingvalue as any as numberRETRY_FAILED_DEPLOYMENTS_DELAY_TIMEms(... ?? '15m')to parse duration stringsAlso fixes the
requireNumbererror message which incorrectly said "string" instead of "number".Test plan
HTTP_SERVER_PORT=7070and verify they're stored as numberscd content && npx jest test/unit/ --no-coverage